Ticket #129 (closed defect: fixed)

Opened 9 months ago

Last modified 8 months ago

fib_verify() always returns BOTS_RESULT_SUCCESSFUL

Reported by: weeks@… Owned by:
Priority: minor Milestone: version 1.2
Component: fib Version: version 1.1.1
Keywords: Cc:
Application Version: omp-tasks Blocked By:
Blocking: Sensitive: no
Needs experiment: no
Experimental observations:

Description

The fib_verify() function in the omp-tasks version of the fib kernel always
returns BOTS_RESULT_SUCCESSFUL; should be:

--- omp-tasks/fib/fib.c.orig    2011-02-11 10:20:00.000000000 -0600
+++ omp-tasks/fib/fib.c 2011-05-15 17:55:06.000000000 -0500
@@ -150,13 +150,13 @@
        if (bots_sequential_flag)
        {
                if (par_res == seq_res) result = BOTS_RESULT_SUCCESSFUL;
-               else result = BOTS_RESULT_SUCCESSFUL;
+               else result = BOTS_RESULT_UNSUCCESSFUL;
        }
        else
        {
                seq_res = fib_verify_value(n);
                if (par_res == seq_res) result = BOTS_RESULT_SUCCESSFUL;
-               else result = BOTS_RESULT_SUCCESSFUL;
+               else result = BOTS_RESULT_UNSUCCESSFUL;
        }

        return result;

Change History

Changed 8 months ago by Xavier Teruel <xavier.teruel@…>

  • status changed from new to closed
  • resolution set to fixed

(In [26c942f71e598c527249edcaf07768ac4b39fd95]) Fixing overflow in Fibonacci benchmark with N equal and greather than 47; applying Nathan Weeks patch. Fixing behind 41th Fibonacci verification; close #129

Changed 8 months ago by Xavier Teruel <xavier.teruel@…>

(In [39672a0acf4428a651924e4b1e31df3827766b00]) Fixing fibonacci OpenMP Tasks verify; Applying Nathan Weeks patch; close #129

Note: See TracTickets for help on using tickets.